Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Tests fail when ran between 23:00 and 00:00 hours (Eastern, -5:00) #976

Closed
sukima opened this issue Mar 7, 2017 · 1 comment
Closed

Tests fail when ran between 23:00 and 00:00 hours (Eastern, -5:00) #976

sukima opened this issue Mar 7, 2017 · 1 comment
Labels
help wanted indicates that an issue is open for contributions

Comments

@sukima
Copy link
Contributor

sukima commented Mar 7, 2017

Expected behavior:

Tests to pass.

Actual behavior:

Some tests fail. Near the top of the list is appointments.

Steps to reproduce:

  1. Change your computer clock time to 23:40 (11:40 PM) Eastern time zone
  2. Run tests in a browser (http://localhost:4200/tests)

Screenshots (if applicable):

screen shot 2017-03-07 at 23 57 40

OS and Browser:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36
mkly added a commit to mkly/hospitalrun-frontend that referenced this issue Mar 7, 2017
@mkly
Add failing tests for appointments after 23:00
8fa9489 
Add failing tests for appointments after 23:00

This sets the time to 23:40 so that the issues described in issue HospitalRun#976
are shown without setting the global system time

Does not resolve issue, only sets test for it
@mkly mkly mentioned this issue Mar 7, 2017
Closed
@mkly
Copy link
Contributor

mkly commented Mar 7, 2017

I was able to recreate this by setting the global time in the acceptance test via sinon.useFakeTimers(). I haven't looked into the actual issue but hopefully the new failing tests may make it easier to resolve.

@sukima sukima mentioned this issue Mar 7, 2017
Merged
@tangollama tangollama added the help wanted indicates that an issue is open for contributions label Mar 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted indicates that an issue is open for contributions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sukima @tangollama @mkly