This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
New OPD Report fields #1003
Merged
New OPD Report fields #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPD Reports Custom Forms
Patient procedures
Fixes from retrospective feedback
fix: fix new user title bug after a new user has been added
Added deploy branches to .travis.yml
fix: fix test for new user title bug
Fix/report acceptance tests
jkleinsc
suggested changes
Mar 20, 2017
There was a problem hiding this comment.
@adeolabadmus thanks for the PR. I realized that the localization is using the wrong hierarchy. It should be reports.labels...., not reports.form....
app/reports/edit/template.hbs
Outdated
| @@ -45,6 +45,27 @@ | |||
|
|
|||
| {{#if isOutPatient}} | |||
|
|
|||
| {{#if visit.visitType }} | |||
| <div class="ps-info-group test-visit-type"> | |||
| <p><b class="test-visit-type-label">{{t 'reports.form.visitType' }}:</b> | |||
There was a problem hiding this comment.
Should be reports.label not reports.form.
| @@ -1255,6 +1255,9 @@ export default { | |||
| date: 'Date', | |||
| author: 'Author' | |||
| }, | |||
| visitType: 'Visit Type', | |||
There was a problem hiding this comment.
I must have missed this on the original PR. These localization values are not organized properly. They appear to be labels, so they should have a labels prefix, not "form". Not sure what "form" refers to but the localizations in this section need to refactored.
jkleinsc
approved these changes
Mar 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #997
Changes proposed in this pull request:
cc @HospitalRun/core-maintainers