Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

1047 remove missed appointments #1050

Merged

Conversation

stoyan-ekupov
Copy link
Contributor

@stoyan-ekupov stoyan-ekupov commented Apr 8, 2017

Fixes #1047 - remove missed appointments.

Changes proposed in this pull request:

  • Remove Router route for appointments.missed and its test
  • Remove app/appointments/missed folder with route handler, controller and template
  • Remove navigation component configuration for appointments.missed
  • Remove navigation.subnav.missedAppointments translations key

Note:
There is an acceptance test named 'visiting /appointments/missed' but actually it tests /appointments url and it is discussed in #691. Maybe the test name should be changed to something more suitable.

cc @HospitalRun/core-maintainers

Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR @StiveK!

@jkleinsc jkleinsc merged commit da388f7 into HospitalRun:master Apr 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants