-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Conversation
Creating a financial summary report…. or learning how.
Got something working enough to check into my branch, but I need some requirements assistance and code review f/ @jkleinsc to bring this home.
The financial summary report should be working now. I need to test it on a larger data set. Need import instructions/assistance from @jkleinsc tomorrow if possible.
@tangollama Can you remove the commented out console.logs? Also, looks like there are some compile warnings you need to fix. See: |
Yes I candor the console logs. As for the warnings, I really wasn't sure how to address those but I'll give it a go. Typed or dictated imperfectly on my iPhone (717.385.9970)
|
Per @jkleinsc request. We should be good now. Can we ship it?
@tangollama the proper way to handle the errors about reject not being used was to use reject properly, not remove it completely. Regardless, I am going to merge this pull request and fix the issue myself. |
Ok thx. I'm happy to get appropriate instruction on that. I couldn't seem to find a context where it worked properly.
|
@tangollama see 73a0138 for how I updated the code to use reject. Basically the concept is we bubble up the errors and display an error message at the top level of the promise chain. |
Convert MedicationsList.test.tsx to RTL
@jkleinsc, I think this is ready to go.