Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Inventory summary report #173

Merged
merged 5 commits into from
Sep 11, 2015
Merged

Inventory summary report #173

merged 5 commits into from
Sep 11, 2015

Conversation

tangollama
Copy link
Member

@jkleinsc, I think this is ready to go.

Creating a financial summary report…. or learning how.
Got something working enough to check into my branch, but I need some
requirements assistance and code review f/ @jkleinsc to bring this home.
The financial summary report should be working now. I need to test it
on a larger data set. Need import instructions/assistance from
@jkleinsc tomorrow if possible.
@jkleinsc
Copy link
Member

@tangollama Can you remove the commented out console.logs? Also, looks like there are some compile warnings you need to fix. See:
https://travis-ci.org/HospitalRun/hospitalrun-frontend/builds/79578002

@tangollama
Copy link
Member Author

Yes I candor the console logs. As for the warnings, I really wasn't sure how to address those but I'll give it a go.

Typed or dictated imperfectly on my iPhone (717.385.9970)

On Sep 10, 2015, at 4:11 PM, John Kleinschmidt notifications@github.com wrote:

@tangollama Can you remove the commented out console.logs? Also, looks like there are some compile warnings you need to fix. See:
https://travis-ci.org/HospitalRun/hospitalrun-frontend/builds/79578002


Reply to this email directly or view it on GitHub.

Per @jkleinsc request. We should be good now. Can we ship it?
@jkleinsc
Copy link
Member

@tangollama the proper way to handle the errors about reject not being used was to use reject properly, not remove it completely. Regardless, I am going to merge this pull request and fix the issue myself.

jkleinsc added a commit that referenced this pull request Sep 11, 2015
@jkleinsc jkleinsc merged commit aba0542 into master Sep 11, 2015
@tangollama
Copy link
Member Author

Ok thx. I'm happy to get appropriate instruction on that. I couldn't seem to find a context where it worked properly.

On Sep 11, 2015, at 9:35 AM, John Kleinschmidt notifications@github.com wrote:

@tangollama the proper way to handle the errors about reject not being used were to use reject properly, not remove it completely. Regardless, I am going to merge this pull request and fix the issue myself.


Reply to this email directly or view it on GitHub.

@jkleinsc
Copy link
Member

@tangollama see 73a0138 for how I updated the code to use reject. Basically the concept is we bubble up the errors and display an error message at the top level of the promise chain.

@jkleinsc jkleinsc deleted the inventory-summary-report branch December 14, 2015 20:52
matteovivona pushed a commit that referenced this pull request Jan 15, 2021
Convert MedicationsList.test.tsx to RTL
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants