-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(patient): add paging and sorting functionality #2026
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/44krzducf |
|
@jackcmeyer, I think test cases are failing because there is no indexing on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackcmeyer, I think test cases are failing because there is no indexing on
Patients
while mockingPatientRepository
. Can you please suggest how to fix this?
It seems like the only issue that you are missing is that searchPaged
needs to be mocked in the ViewPatients.test.tsx
suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely headed down the right path! nice work @akshay-ap!
Change Page interface, Fix failing tests fix HospitalRun#1969
@akshay-ap do you need help? |
Any kind of help will be welcome!!! Code review, contribution, suggestions for this PR. :) |
Fixes #1969
Changes proposed in this pull request:
PageComponent
(Shows: Previous Button, Current Page Number, Next Button)Patient[]
inPage<Patient>
Patient
searchPaged
andfindAllPaged
in PatientRepository