This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(i18n): add new script for checking missing translations #2034
Merged
matteovivona
merged 56 commits into
HospitalRun:master
from
marcosvega91:feature/check_translations
Jun 10, 2020
Merged
feat(i18n): add new script for checking missing translations #2034
matteovivona
merged 56 commits into
HospitalRun:master
from
marcosvega91:feature/check_translations
Jun 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I add new dep for running typscript script(ts-node). I update the linter path for checking the new folder scripts. With the command yarn translation:check you can check if some translations are missing. All erros will print in the console fix #1919
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/4fmg5n0wn |
matteovivona
changed the title
feat(add new script for checking missing translations): translations
feat(i18n): add new script for checking missing translations
May 2, 2020
matteovivona
added
devops
issue/pull request that includes changes to documentation to devops processes
localization
and removed
devops
issue/pull request that includes changes to documentation to devops processes
labels
May 2, 2020
…hospitalrun-frontend into feature/check_translations
I didn't understend why webstorm created a file json in the root 🤮. I deleted it |
jackcmeyer
suggested changes
May 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super awesome stuff!
Run yarn translation:check before yarn start and yarn test
add library chalk to make logs more colored
now ts-node library is no need anymore because the script is compiled to javascript
…hospitalrun-frontend into feature/check_translations
fox1t
previously approved these changes
Jun 8, 2020
Awesome! |
…hospitalrun-frontend into feature/check_translations
I see that something was wrong with build. I fixed that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🚀enhancement
an issue/pull request that adds a feature to the application
in progress
indicates that issue/pull request is currently being worked on
localization
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1919
Changes proposed in this pull request:
folder scripts
missing
When you run the command It will print some information of the library i18next because the debug is active
Newly added dependencies with Bundlephobia links:
Note: pull requests without proper descriptions may simply be closed without further discussion. We appreciate your contributions, but need to know what you are offering in clearly described format. Provide tests for all code that you add/modify. If you add/modify any components update the storybook. Thanks! (you can delete this text)