This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Fixes #485: Suggest next patient ID based on the largest number used #667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggested patient ID keeps getting incremented even if we cancelled the new patient form. This problem should be related to issue #485 and more info can be found in #485 (comment).
I try to solve the problem by saving the current sequence rather than the next available one. We start checking from the current sequence when preparing a new patient form. The value would be incremented and saved only if it has already been taken. So, no matter how many times we click the cancel button, the suggested patient ID would always be the same.
Please correct me!
cc @HospitalRun/core-maintainers