-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Conversation
@mdarmani thanks for the PR! Can you update the description of what you changed? I know this is a simple change, but it really helps us a project maintainers to understand what PRs are intended for. I specifically mean this text below should be replaced. If your PR doesn't fix an issue you can drop that part out, but there should be some kind of description of the change. Changes proposed in this pull request:
Note: pull requests without proper descriptions may simply be closed without further discussion. We appreciate your contributions, but need to know what you are offering in clearly described format. Thanks! (you can delete this text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition, I think the text should be slightly tweaked as suggested below:
@@ -48,7 +48,7 @@ To install the frontend please do the following: | |||
## Start | |||
To start the frontend please do the following: | |||
|
|||
- Start the server by running `npm start` in the repo folder. | |||
- Start the server by running `npm start` in the repo folder. In some cases, that will not work so try `ember serve`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saying "In some cases" is kind of confusing. Maybe you could say something like, if npm start doesn't work you you, you can try ember serve as an alternative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a slight grammar tweak.
@@ -48,7 +48,7 @@ To install the frontend please do the following: | |||
## Start | |||
To start the frontend please do the following: | |||
|
|||
- Start the server by running `npm start` in the repo folder. | |||
- Start the server by running `npm start` in the repo folder. If `npm start` doesn't work you, try `ember serve` as an alternative. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant to say "If npm start
doesn't work for you
@mdarmani Looks good to me. Thanks for the PR! I'll merge it in. |
Fixes #[replace brackets with the issue number that your pull request addresses].
Changes proposed in this pull request:
cc @HospitalRun/core-maintainers