This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Add abstract controller unit tests and translations #900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
stubbing methods for proper test coverage
@todo
about possible unintended behaviorof the
sortByKey
actionThe tests in this commit preserve the behavior as implemented. It is
possible that
sortByKey
should also setnextStartKey
andstartKey
to
null
as well._notifyReportError
inabstract-report-controller
_notifyReportError
_setReportTitle
in abstract-report-controller_setReportTitle
with translationsFinally needed the sinon devDependency here. I'll circle back after this is merged and pull the timekeeper stuff out.
Not 100% sure of where I should be putting the translations in the locale file. Just making a best guess so definitely let me know if I should move them to a better spot.
This is all in one big PR because of later tests needing sinon as well. I tried to keep the commits clean, so when reviewing it is probably easiest for you to step through the commit diffs if you are looking to get a closer look at the changes.
cc @HospitalRun/core-maintainers