-
-
Notifications
You must be signed in to change notification settings - Fork 643
feat: graphql #371
base: master
Are you sure you want to change the base?
feat: graphql #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM however we should remove mongoose from the project. Usually, it becomes a major pain and bottleneck when using mongodb in production.
"make-promises-safe": "~5.1.0", | ||
"mercurius": "~6.3.0", | ||
"mongoose": "~5.10.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not going to use mongoose since it is really slow and it will become a major bottleneck soon. For the moment we can leave just the mongodb driver
}, | ||
"devDependencies": { | ||
"@commitlint/cli": "~11.0.0", | ||
"@commitlint/config-conventional": "~11.0.0", | ||
"@commitlint/prompt": "~11.0.0", | ||
"@types/glob": "~7.1.1", | ||
"@types/mkdirp": "~1.0.0", | ||
"@types/mongoose": "~5.7.36", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this.
// fastify.register(fastifyHelmet) | ||
fastify.register(mercurius, { | ||
defineMutation: true, | ||
} as any) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the types wrong here? If so we can make a PR to mercurius.
import mongoose, { Schema, Types } from 'mongoose' | ||
import Patient from '../model/Patient' | ||
|
||
const PatientSchema = new Schema({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use json schema for the schemas so we can add them to fastify too when needed.
"fastify-plugin": "~3.0.0", | ||
"graphiql": "~1.0.5", | ||
"graphql-tools": "~7.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed a comma here which is causing build failure. Thankyou
|
No description provided.