Ruff linting #79
Ruff linting #79
Conversation
| discovery_enabled : bool = False | ||
| json : bool = False | ||
| reconnect_delay : int = 7 | ||
| ''' seconds ''' |
There was a problem hiding this comment.
''' is prefered over # for commenting variable defs for my ide.
doesnt show on my ide when hovering variables.
minor thing
classes/transports/modbus_base.py
Outdated
| if not self.protocolSettings.validate_registry_entry(entry, current_value): | ||
| raise ValueError("Invalid value in register. unsafe to write") #i need to figure out a better error handler for theese. | ||
|
|
||
| # if not self.protocolSettings.validate_registry_entry(entry, current_value): |
There was a problem hiding this comment.
i would like to keep this in.
adding a transport setting to handle disabling this would be the "proper" way todo it.
validating the "current value" is important for detecting the accuracy of the register definitions. ie, making sure your not writting to the wrong reigster.
maybe a
allow_unsafe_writes = True
setting could be added.
There was a problem hiding this comment.
Woops. That was my hack to get writing to work in that other issue. I'll revert.
|
|
||
| size = len(packet) | ||
| crc = computeCRC(packet) | ||
| crc2 = calculate_crc(packet,size) |
There was a problem hiding this comment.
hmm. i'm not sure if i completed the pace transport. i think it's still a work in progress.
There was a problem hiding this comment.
I'll put this back then, but comment it out.
|
looks good. ty for contributing. |
2 participants
This is a work-in-progress branch to slowly add some common code standards using Ruff. As to not make one massive branch, this PR only fixes pycodingstyle rules, and basic code-error checks from pyflakes. You can see these rules in effect inside ruff.toml.
Checking is simple:
ruff checkto check the entire codebase.Over time, more rules can be added. Inside ruff.toml, commented out, you can see the ruleset/ignores I typically use in my projects.