Issue #166 - Using Stripe tokenization to send credit card information for processing #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. Relating to Issue #166. |
WillStrohl
changed the title
|
Hello @joshgk00 : Have you tested this yourself yet? I'm looking at merging this tonight? I'll be testing this myself, but I wanted to see what kind of tests you may have run so far. |
|
Yes @hismightiness , I've run some tests with valid and invalid cards. So far all seems to be working. I have a client that has been using the change in their production for almost a year now. No reported issues so far. |
|
Outstanding to know! I'll be doing the rest of the review and merging process later today or this evening. Thanks again! |
|
This looks good, Josh. Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.