Issue #20 - Items cannot be added to cart if .NET incorrectly detects browser cookie capability #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These updates assume that (1) the request context always won't be null; and (2) cookies are always supported. While I understand why they're implemented the way they are, isn't there a higher chance of Null Reference Exceptions on both the request and cookie objects with this? |
|
The HttpContext could potentially be null, but that's already checked. The Request object will always be initialised by the point in the lifecycle at which we're accessing it, and the Cookies collection is also non-null - if no Cookie headers were received, it will simply be empty. P.S. We have this code tested and running in production :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20.
Removed unnecessary and potentially damaging browser capability checks. Browsers erroneously detected as not supporting cookies could not retain shopping cart state.