Fix Installer generated by HCC (BUG) #413
Conversation
In previous versions of Hotcakes and there was a library called Hotcakes.Shipping.Ups.Keys, this was removed in the latest version but they forgot to remove the reference within the manifest so when we try to install the extension we get this error. I have corrected this within the manifest. I compiled the installer again and it installed successfully. The solution was simply to delete the Assembly reference within the manifest.
|
FYI - This isn't the correct fix for this issue. If the DLL is missing, the fix isn't to remove the code that expects it to be there. The code should be updated to be sure to move the DLL. This is most likely a bug in the build process, not the DNN manifest. The way this PR is done, the DLL still won't be copied, but DNN won't complain about it, because there isn't a reference to it. |
|
I was reviewing the previous Releases of Hotcakes and there was a library with the name Hotcakes.Shipping.Ups.Keys
this was removed in the last release
but they forgot to remove the reference inside the manifest, so when we try to install the extension we get this error.
As shown it seems that this library was removed in some update It may have happened here: Replace Ups registration with login #398 |
|
Ah! Thank you for pointing that out. I (obviously) completely missed that. 😎 |
Optimization of the FindManyWithCache method. Reduction of multiple traversals via foreach to input parameters. A reduction to only one was made. The call to the FindMany method was changed by a call to the Find method that already inside it adds the product to the cache storage
This reverts commit 180400d.
|
The Update Method FindManyWithCache commit was an error, so it was reverted. As the PullRequest Fix Installer generated by HCC (BUG) #413 was approved but was not merged, the new change was added within the same branch. I reverted the change and created a new branch with the new changes. |
Removed unnecessary assembly reference within the manifest.
Fixed #412