Issue/replace pay pal pro #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update PayPal Pro implementation
correcting the resourcekey
Fixing PR comments
Issue/395
Fix the API error in the Authorize request method
WillStrohl
requested changes
Jan 12, 2023
| { | ||
| Number = creditCardNumber, | ||
| Expiry = $"{expYear}-{expMonth}", | ||
| Name = "John Doe", |
There was a problem hiding this comment.
Why is this using "John Doe"?
|
@VAlmea Oh, your close comment is attempting to close the previous PR and not the original Issue. :) |
WillStrohl
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are present all the necessary changes to update the implementation of PayPal Pro. Also removed unnecessary classes and references. There is also a little modification to the class startPayPalExpressCheckout.cs that I realized was needed when I removed the reference to the old paypal_base.dll.
close #49