Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data in formats other than HTML left unprotected #6

Closed
wkrsz opened this issue Dec 21, 2012 · 2 comments
Closed

Data in formats other than HTML left unprotected #6

wkrsz opened this issue Dec 21, 2012 · 2 comments

Comments

@wkrsz
Copy link
Contributor

wkrsz commented Dec 21, 2012

Our app happily gives the data away without second factor if you just ask it for JSON.

https://github.com/Houdini/two_factor_authentication/blob/master/lib/two_factor_authentication/controllers/helpers.rb#L13
@Houdini
Copy link
Owner

Houdini commented Dec 21, 2012

Thanks for issue, I'll investigate it in close future

wkrsz added a commit to wkrsz/two_factor_authentication that referenced this issue Dec 21, 2012
@wkrsz
Respond with 401 for request non-HTML requests [Houdini#6]
ab768d4
@Houdini
Copy link
Owner

Houdini commented Jan 10, 2013

Thanks

@Houdini Houdini closed this as completed Jan 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Houdini @wkrsz