Skip to content

Conversation

@newtrat
Copy link
Contributor

@newtrat newtrat commented Mar 14, 2017

Removes a deprecation warning from OpenSSL, and updates a test to use the new encryption algorithm from #111.

newtrat added 2 commits March 14, 2017 19:01
OpenSSL::Cipher::Cipher has been deprecated in favor of OpenSSL::Cipher
Since  now always includes ,
the test for passing the correct options to Encryptor should also include
that option.
@newtrat
Copy link
Contributor Author

newtrat commented Mar 15, 2017

Sorry, I didn't realize backticks weren't accepted in git commit messages. The commit message for 57517e5 should say

Since encryption_options_for now always includes algorithm: 'aes-256-cbc',
the test for passing the correct options to Encryptor should also include
that option.

@rmm5t
Copy link
Contributor

rmm5t commented May 1, 2017

I'd love to see this pulled in when you get a chance. I'm looking into relying on the master branch in preparation for the eventual 2.0 release, but I'd much prefer tracking commits that have a passing build matrix.

@Houdini Houdini merged commit 20c9d14 into Houdini:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants