Add generators to make it easier to install and fix deprecation warnings #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no longer included automatically."
Houdini
added a commit
that referenced
this pull request
May 17, 2012
Add generators to make it easier to install and fix deprecation warnings
|
I like your changes, |
filipeperdigaosousa
pushed a commit
to filipeperdigaosousa/two_factor_authentication
that referenced
this pull request
Nov 12, 2018
* Add compat with older versions of devise * Update to new ruby syntax and styleguide * Update for style guides * Add new and create method to add a totp code via QR * Add issuer to config to set issuer via provisioning_uri * Add db column for otp enabled status * Change routing by adding verify path and using edit/update to disable otp * Update creating and updating otp on user * Add routing to new_user_two_factor_authentication if otp is not enabled but is tfa is needed * Rename set_qr method and remove unused settings * Add enable, confirm and disable methods * Updat readme for new functionalities * Add view generator and documentate in readme * Update test for new database field * Remove issuer option * Update controller spec for verify route instead of update * Fix test for added otp_enabled attribute * Add feature and controller tests * Refactor routes resources * [PR Feedback] Use Devise::Version over respond_to? * Fix test for new otp_enabled field * Add notice for successful disable of tfa * Save changes after enabling and disabling otp * Remove commented code * Update edit view
newstler
pushed a commit
to CPInc/two_factor_authentication
that referenced
this pull request
Mar 10, 2021
…ween-cookie-styles Make it more graceful switching between multi user and not
vicomte
referenced
this pull request
in vicomte/two_factor_authentication
Aug 15, 2022
Show authentication type in the json response when 2fa required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have been working a bit in this project and made a few changes that I would like to submit:
Do you agree with these changes?
Also, are you planning to release the gem, or will you keep it only on github?
Thanks.