Improve examples #16
Open
Improve examples #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comma only appeared in cases where there were a few optimisations in a single `opt' call: `closureInstance....... 330061782 no preopt, interp interp opt, turbofan` An arrow has been added to distinct optimization steps in the final log: `closureInstance....... 213392979 no preopt -> interp -> interp -> opt, turbofan`
`closureInstance` used to return a function instead of an object instance
Assigned the prototype with `age` property for `data1` elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final log in
2-benchmarkhas been changed.Comma only appeared in cases where there were a few optimisations in a single
optcall:closureInstance....... 330061782 no preopt, interp interp opt, turbofanAn arrow has been added to distinct optimization steps in the final log:
closureInstance....... 213392979 no preopt -> interp -> interp -> opt, turbofanclosureInstancein3-instantiationhas been fixed. Previously it returned a function instead of an object instance.In
4-arraydata1elements didn't haveageproperty, so the query filter always failed.This issue has already been addressed in #15, but I believe it is better to create a separate prototype for objects rather than using the same one as for arrays.