Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to react-md@v2 #17

Closed
10 of 12 tasks
carlgieringer opened this issue Jul 9, 2021 · 2 comments · Fixed by #606
Closed
10 of 12 tasks

Upgrade to react-md@v2 #17

carlgieringer opened this issue Jul 9, 2021 · 2 comments · Fixed by #606
Assignees
@carlgieringer
Labels
clean code Work to improve the codebase
Milestone
P1

Comments

@carlgieringer
Copy link
Contributor

carlgieringer commented Jul 9, 2021 •
edited
Loading

Also we should consider cross platform frameworks: https://docs.google.com/spreadsheets/d/1Wrpe54CDwLzlAJ2QJgiMRyQ3hAaNnGpfhtCKAJ2OurU/edit

Upgrade steps:

  • Buttons
  • Dialogs (CreateJustificationDialog and transclusion)
  • Cards
  • Progress
  • TextFields
  • Menus, Dividers
  • Switch/SelectionControlGroup
  • Chip
  • Autocomplete
  • Grid (see LoginPage)
  • App/Nav (TabsProps, Toolbar, Drawer, Snackbar, Tabs)
  • Form that displays model's ErrorMessages?
@carlgieringer carlgieringer added the clean code Work to improve the codebase label Jul 9, 2021
@carlgieringer carlgieringer added this to the P1 milestone Jul 9, 2021
@carlgieringer carlgieringer self-assigned this Oct 9, 2022
@carlgieringer carlgieringer removed their assignment Mar 4, 2023
@carlgieringer
Copy link
Contributor Author

We'll do #304 instead.

@carlgieringer
Copy link
Contributor Author

carlgieringer commented Apr 21, 2023 •
edited
Loading

Actually we might upgrade react-md first. It's a good idea to convert most of the web app components to TS first so that typechecking helps us find any errors. We can use this command to find React components that haven't been converted to TS yet:

find . -type f -name "[[:upper:]]*.js"

Some items:

  • Use messageProps instead of ErrorMessages/direct FormMessage.

@carlgieringer carlgieringer reopened this Apr 21, 2023
@carlgieringer carlgieringer mentioned this issue Jul 13, 2023
Open
@carlgieringer carlgieringer mentioned this issue Aug 5, 2023
Closed
@carlgieringer carlgieringer mentioned this issue Aug 23, 2023
Open
@carlgieringer carlgieringer mentioned this issue Sep 11, 2023
Open
@carlgieringer carlgieringer self-assigned this Oct 8, 2023
@carlgieringer carlgieringer mentioned this issue Oct 22, 2023
Merged
carlgieringer added a commit that referenced this issue Oct 22, 2023
@carlgieringer
Address remaining TODOs for #17
ef8beb5 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlgieringer carlgieringer

Labels
clean code Work to improve the codebase
Projects
Refactoring project
Status: Done
Milestone
P1
Development

Successfully merging a pull request may close this issue.

Remove react-md@1 Howdju/howdju
1 participant
@carlgieringer