Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating a justification based on an existing proposition #387

Merged
merged 8 commits into from
Apr 20, 2023
Merged

Fix creating a justification based on an existing proposition #387

merged 8 commits into from
Apr 20, 2023

Conversation

carlgieringer
Copy link
Contributor

@carlgieringer carlgieringer commented Apr 20, 2023 •
edited
Loading

fixes #385

  • Remove .strict from Entity schemas (instead rely on the default .strip behavior so that it's convenient to pass Out models as Input models.
  • Fix a XSS vulnerability where we allowed javascript: URLs.

@carlgieringer
Fix and cover creating a justification based on an existing propositi…
3c29397 
…on (fixes #358)

Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer carlgieringer linked an issue Apr 20, 2023 that may be closed by this pull request
Cannot justify existing proposition with existing proposition #385
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 20, 2023
View reviewed changes
premiser-ui/src/CreatePropositionPage.tsx
onPersorgAutocomplete = (persorg: PersorgOut, index: number) => {
this.props.dispatch(
})(),
[mode, dispatch, queryParams]

Check warning

Code scanning / CodeQL

Client-side cross-site scripting (experimental)

(Experimental) This may be a cross-site scripting vulnerability due to [a user-provided value](1). Identified using machine learning.
@carlgieringer
Add check:yarn-install to check:everything
0bdfff5 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Apr 20, 2023 •
edited
Loading

Changed-files coverage summary


=============================== Coverage summary ===============================
Statements   : 72.97% ( 783/1073 )
Branches     : 57.75% ( 231/400 )
Functions    : 70.23% ( 151/215 )
Lines        : 72.69% ( 772/1062 )
================================================================================

@carlgieringer
Fix build for expectToBeSameMomentDeep
0989325 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer
Remove do not merge
41178e5 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer
Add check:yarn-install
42fcdd9 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer
Disallow javascript: URLs
c63b99d 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer
Fix test build
671a2e3 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer
PR edits (fix urlString domain validation)
15ab6a6 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer carlgieringer merged commit df51310 into master Apr 20, 2023
@carlgieringer carlgieringer deleted the features/358-cant-justify branch April 20, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot justify existing proposition with existing proposition
1 participant
@carlgieringer