Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mailchimp and fix GH deploy actions #620

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Remove mailchimp and fix GH deploy actions #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
775046b
Remove mailchimp
carlgieringer Nov 8, 2023
1718041
Use literal for node-version
carlgieringer Nov 8, 2023
40b0869
Use correct GH action syntax for repository variables
carlgieringer Nov 8, 2023
49ec964
Fix reference to YARN_VERSION
carlgieringer Nov 8, 2023
ecb0523
Fix YAML syntax
carlgieringer Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ jobs:
- name: Setup Node.JS
uses: actions/setup-node@v3
with:
node-version: $NODE_VERSION
node-version: ${{ vars.NODE_VERSION }}
cache: "yarn"
- name: Install Yarn
run: |
corepack enable
yarn set version $YARN_VERSION
yarn set version ${{ vars.YARN_VERSION }}
- name: Install dependencies
run: yarn install
- name: Lint
Expand Down Expand Up @@ -127,12 +127,12 @@ jobs:
- name: Setup Node.JS
uses: actions/setup-node@v3
with:
node-version: $NODE_VERSION
node-version: ${{ vars.NODE_VERSION }}
cache: "yarn"
- name: Install Yarn
run: |
corepack enable
yarn set version $YARN_VERSION
yarn set version ${{ vars.YARN_VERSION }}
- name: Install dependencies
run: yarn install
- name: Changed-files test coverage
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/deploy-preprod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ jobs:
- name: Node.js
uses: actions/setup-node@v3
with:
node-version: $NODE_VERSION
node-version: ${{ vars.NODE_VERSION }}
- name: Corepack
# Enables yarn v2
run:
run: |
corepack enable
yarn set version $YARN_VERSION
yarn set version ${{ vars.YARN_VERSION }}
- name: Yarn install
run: yarn install
- name: Deploy API
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/deploy-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@ jobs:
aws-region: ${{ env.AWS_REGION }}
- uses: actions/setup-node@v3
with:
node-version: $NODE_VERSION
node-version: ${{ vars.NODE_VERSION }}
- name: Corepack
# Enables yarn v2
run:
run: |
corepack enable
yarn set version $YARN_VERSION
yarn set version ${{ vars.YARN_VERSION }}
- name: Yarn install
run: yarn install
- name: Update API Lambda Alias
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/flaky-tests-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ jobs:
- name: Setup Node.JS
uses: actions/setup-node@v3
with:
node-version: $NODE_VERSION
node-version: ${{ vars.NODE_VERSION }}
cache: "yarn"
- name: Install Yarn
run: |
corepack enable
yarn set version $YARN_VERSION
yarn set version ${{ vars.YARN_VERSION }}
- name: Install dependencies
run: yarn install
- name: Check flaky tests
Expand Down
27 changes: 0 additions & 27 deletions premiser-ui/src/LoginPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,33 +142,6 @@ class LoginPage extends Component<Props> {
</form>
</CardContent>
</Card>
<Card>
<CardContent>
Howdju 2.0 is currently in private gamma. Enter your email to sign
up for updates:
</CardContent>
<CardContent>
<form
action="//howdju.us16.list-manage.com/subscribe/post?u=ccf334287da1fbf7af0904629&amp;id=f08c3a775d"
method="post"
target="_blank"
// https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel/noopener
{...{ rel: "noopener" }}
>
<EmailField id="mce-email" name="EMAIL" required />
<input
type="hidden"
name="b_ccf334287da1fbf7af0904629_f08c3a775d"
tabIndex={-1}
/>
<CardActions>
<SolidButton type="submit" name="subscribe">
Subscribe
</SolidButton>
</CardActions>
</form>
</CardContent>
</Card>
</SingleColumnGrid>
</Page>
);
Expand Down