Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make top tab nav reliable #632

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Make top tab nav reliable #632

merged 1 commit into from
Feb 12, 2024

Conversation

carlgieringer
Copy link
Contributor

@carlgieringer carlgieringer commented Feb 11, 2024

I had to add another tab Home or else the active tab highlight wouldn't move away from the previous tab when I navigated home. (Besides having an explicit Home tab is probably a good idea for usability.) I actually have no idea why navigating home (say using the logo in the upper left) correctly updates the tab highlight to the Home tab. But it works.

Long term solution might be to use a different tab component that lets us control what appears on the page using react-router.

Fixes #630

Copy link

Changed-files coverage summary


=============================== Coverage summary ===============================
Statements   : Unknown% ( 0/0 )
Branches     : Unknown% ( 0/0 )
Functions    : Unknown% ( 0/0 )
Lines        : Unknown% ( 0/0 )
================================================================================

Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer carlgieringer force-pushed the features/630-fix-tab-nav branch from 0af40c5 to cf95a7e Compare February 11, 2024 23:40
@carlgieringer carlgieringer merged commit b65684b into master Feb 12, 2024
5 checks passed
@carlgieringer carlgieringer deleted the features/630-fix-tab-nav branch February 12, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigating using the top tabs is unreliable
1 participant