Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure lambdas from parameter store #658

Merged
merged 5 commits into from
Mar 17, 2024
Merged

Configure lambdas from parameter store #658

merged 5 commits into from
Mar 17, 2024

Conversation

carlgieringer
Copy link
Contributor

@carlgieringer carlgieringer commented Mar 14, 2024 •
edited
Loading

Fixes #18.

TODO:

  • release howdju-message-handler
  • release proposition-tag-scorer

@carlgieringer
Simplify Database transaction handling
7eb84b8 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer carlgieringer self-assigned this Mar 14, 2024
@carlgieringer
Make getting a DB connection async (prep for async DB config)
bafaf15 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer carlgieringer force-pushed the features/18-secrets-manager branch from 8aea280 to bafaf15 Compare March 14, 2024 14:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

Changed-files coverage summary


=============================== Coverage summary ===============================
Statements   : 68.55% ( 1116/1628 )
Branches     : 58.18% ( 359/617 )
Functions    : 71.61% ( 285/398 )
Lines        : 68.28% ( 1089/1595 )
================================================================================

@carlgieringer
Load database connection info from parameter store
35e6060 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer carlgieringer mentioned this pull request Mar 17, 2024
Closed
@carlgieringer
PR edits
df84830 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer
Fix message handler test
197844d 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer carlgieringer merged commit 6a5b9e7 into master Mar 17, 2024
5 checks passed
@carlgieringer carlgieringer deleted the features/18-secrets-manager branch March 17, 2024 20:24
@carlgieringer carlgieringer added the requires lambda release Requires a manual deployment of one or more Lambdas (not the API) label Mar 17, 2024
@carlgieringer carlgieringer mentioned this pull request Mar 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@carlgieringer carlgieringer

Labels
requires lambda release Requires a manual deployment of one or more Lambdas (not the API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read database credentials from AWS Secrets Manager
1 participant
@carlgieringer