Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle instructions with relative ip and immediate value #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kerrytazi
Copy link

Fixes #42

@Hpmason
Copy link
Owner

Hpmason commented Jan 4, 2025

Sorry I've been busy with work, life and holidays. The code looks good, just one thing I tried to spend time on months ago, would you be able to create a unit test that shows that the original issue is resolve. I believe these changes fixes it, but I was not able to write a unit test that fails prior to these changes in the time I had to work on it.

If you or someone else can write that test, I would be comfortable merging this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with RIP relative addressing
2 participants