Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo file upload project #6

Open
HriBB opened this issue Dec 7, 2016 · 6 comments
Open

Apollo file upload project #6

HriBB opened this issue Dec 7, 2016 · 6 comments

Comments

@HriBB
Copy link
Owner

HriBB commented Dec 7, 2016

@sandervanhooft @thebigredgeek if you want, I can give you admin access to all repositories for apollo file upload. You guys are very active and I am really busy ATM, so I think it's best if we work together. Maybe we can even create a new organization/repository and use lerna and typescript in the same way as graphql-server.

In any case, we should discuss some things, because I think that apollo core devs are busy with 1.0, so I guess it's up to us to create something that works. What do you guys think?

@thebigredgeek
Copy link
Collaborator

Yup! I am down :)

@sandervanhooft
Copy link
Collaborator

sandervanhooft commented Dec 8, 2016 via email

@HriBB
Copy link
Owner Author

HriBB commented Dec 8, 2016

OK great! I've made you both collaborators on all three projects.

What do you think about lerna and typescript?

@sandervanhooft
Copy link
Collaborator

sandervanhooft commented Dec 8, 2016 via email

@HriBB
Copy link
Owner Author

HriBB commented Dec 8, 2016

Lerna allows you to have one repo but export multiple npm packages. Take a look at graphql-server, which uses it to publish multiple packages to npm: graphql-server-core, graphql-server-express, graphql-server-koa and graphql-server-hapi.

@sandervanhooft
Copy link
Collaborator

@HriBB That seems valuable to express-upload / koa-upload for sure!

I don't see the value for this client, other than that it may come in handy if there are subtle differences with the react-native implementation.

@stubailo
Perhaps the apollo core team has some resources available to help us lay the initial ground work? I.e. typescript + testing + lerna + apollo client hooks boilerplate? That would be a major (quality) booster, there's no use to reinvent the wheel here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants