DOMParser.parseFromString() throws a TypeError

HtmlUnit · Feb 2, 2025 · da28a83 · da28a83
1 parent 1cf107e
commit da28a83
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,9 @@
 
     <body>
         <release version="4.10.0" date="February xx, 2025" description="Bugfixes">
+            <action type="fix" dev="rbri">
+                DOMParser.parseFromString() throws a TypeError.
+            </action>
             <action type="fix" dev="rbri">
                 Window.postMessage() throws a SyntaxError.
             </action>

diff --git a/src/main/java/org/htmlunit/javascript/host/dom/DOMParser.java b/src/main/java/org/htmlunit/javascript/host/dom/DOMParser.java
@@ -69,12 +69,12 @@ public Document parseFromString(final String str, final Object type) {
         try {
             final Document document = parseFromString(this, str, type);
             if (document == null) {
-                throw JavaScriptEngine.reportRuntimeError("Invalid 'type' parameter: " + type);
+                throw JavaScriptEngine.typeError("Invalid 'type' parameter: " + type);
             }
             return document;
         }
         catch (final IOException e) {
-            throw JavaScriptEngine.reportRuntimeError("Parsing failed" + e.getMessage());
+            throw JavaScriptEngine.syntaxError("Parsing failed" + e.getMessage());
         }
     }
 
@@ -93,7 +93,7 @@ public Document parseFromString(final String str, final Object type) {
     public static Document parseFromString(final HtmlUnitScriptable scriptable, final String str, final Object type)
                 throws IOException {
         if (type == null || JavaScriptEngine.isUndefined(type)) {
-            throw JavaScriptEngine.reportRuntimeError("Missing 'type' parameter");
+            throw JavaScriptEngine.typeError("Missing 'type' parameter");
         }
 
         if (MimeType.TEXT_XML.equals(type)