Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-Alt keybinds conflicts #115

Closed
enkol opened this issue Aug 10, 2017 · 5 comments
Closed

Ctrl-Alt keybinds conflicts #115

enkol opened this issue Aug 10, 2017 · 5 comments

Comments

@enkol
Copy link

enkol commented Aug 10, 2017

On some international keyboard layouts, the AltGr key is used to type some characters.
Due to not all keyboards having an AltGr key, the combination Ctrl-Alt is a substitute for AltGr.

With german layout this is the case for the @ symbol, which is typed with AltGr-Q.
Therefore, trying to type an @ symbol, conflicts with Rest-Clients Ctrl-Alt-Q shortcut. The same is the case for Ctrl-Alt-E, which conflicts with typing € symbol.

This results in not being able to type @ for delcaring a local variable in a .rest file, when using a german keyboard layout.

Because of such conflicts, it's advised to not use Ctr-Alt for shortcuts. As there may be other conflicts with other languages layouts. See https://en.wikipedia.org/wiki/AltGr_key

To fix this, either change the default shortcuts or at least add a note in the extensions readme about this possible shortcut problems, so users are told why they may not be able to type @. Should then also recommend to change the "Cancel Request" shortcut (and maybe others) via vscode settings, when expierincing such problems.

  • VSCode Version: 1.14.2
  • OS Version: Windows 10
  • REST Client Version: 1.5.1

Steps to Reproduce:

  1. Change OS keyboard layout to German
  2. In vscode open a *.rest or *.http file
  3. Try to type the @ symbol by pressing AltGr-Q or Ctrl-Alt-Q
@Huachao
Copy link
Owner

Huachao commented Aug 11, 2017

@enkol thanks for your suggestion, and I'd like to modify the keyboard shortcut Ctrl+Alt+K to Ctrl+Alt+K. Do you think it's ok, and it seems it works for German keyboard

Huachao added a commit that referenced this issue Aug 11, 2017
@Huachao Huachao closed this as completed Aug 11, 2017
@enkol
Copy link
Author

enkol commented Aug 11, 2017

Ctrl-Alt-K is fine with German keyboard layout.

According to https://en.wikipedia.org/wiki/AltGr_key, Ctrl-Alt-K is used for South Slavic Latin, Latvian, Macedonian and Belgian layout. But it's not for a critical character, like it was with German layout (@).

@Huachao
Copy link
Owner

Huachao commented Aug 11, 2017

@enkol thanks so much, as you said for other keyboard layouts Ctrl+Alt+K is not critical, so I'd like to keep it.

@Huachao
Copy link
Owner

Huachao commented Aug 22, 2017

@enkol you could use the latest version 0.15.2 to verify new keybinding Ctrl+Alt+K 😄

@enkol
Copy link
Author

enkol commented Aug 22, 2017

I can verify that Ctrl-Alt-Q isn't used anymore, so there is no more conflict with typging the @ Symbol.
I did not test Ctrl-Alt-K canceling a request (i've no quickly available text case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants