Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers missing in Request #465

Closed
swiffer opened this issue Dec 23, 2019 · 3 comments
Closed

Headers missing in Request #465

swiffer opened this issue Dec 23, 2019 · 3 comments

Comments

@swiffer
Copy link

swiffer commented Dec 23, 2019

  • VSCode Version: 1.41.1
  • OS Version: Windows Version 1909
  • REST Client Version: 0.23.0

Steps to Reproduce:

  1. Add Cookie to rest-client.defaultHeaders
  2. Execute Request / Copy request as CURL

The request is getting executed without Headers added. Copy request as CURL is not adding the Headers from config. Headers defined in .http Request are applied to Copy request as CURL but not when sending the request. However the history is showing the requests with headers applied.

@Huachao
Copy link
Owner

Huachao commented Dec 24, 2019

@swiffer I have partially fixed the issue that user-provided Cookie headers (no matter in default headers config or .http file) will be respected when sending the request. And Copy Request As cURL behavior is unchanged and only Cookie headers provided in the .http file are respected, and this is the same behavior like other HTTP client tools like Postman. I think it's OK for now, so I'd like to close it for now.

@Huachao Huachao closed this as completed Dec 24, 2019
@swiffer
Copy link
Author

swiffer commented Jan 20, 2020

@Huachao Thanks! It would be really nice to have a fixed version released, downgraded to 0.22.2 temporary. (see #482 for same problem)

@Huachao
Copy link
Owner

Huachao commented Jan 21, 2020

@swiffer I have fixed this issue in the latest version 0.23.1 and you can verify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants