Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$filter GET query param broken in 0.24.1 (but works in 0.23.2) #635

Closed
vobu opened this issue Jul 7, 2020 · 3 comments
Closed

$filter GET query param broken in 0.24.1 (but works in 0.23.2) #635

vobu opened this issue Jul 7, 2020 · 3 comments

Comments

@vobu
Copy link

vobu commented Jul 7, 2020

  • REST Client Version: 0.24.1 (but works with v0.23.2)
  • VSCode Version: 1.46.1
  • OS Version: macOS 10.15.5

Steps to Reproduce:

  1. construct an (OData) GET query with a $filter parameter, e.g.
https://{{host}}/some/odata/endpoint
?$top=100
&$filter=property eq null
  1. Send Request -> error:
RequestError: Method must be a valid HTTP token ["HTTPS://HOST.EX.ORG/SOME/ODATA/ENDPOINT?$TOP=100&$FILTER=PROPERTY"]
	at L (/Users/<user>/.vscode/extensions/humao.rest-client-0.24.1/dist/extension.js:252:3866)
	at async Immediate.<anonymous> (/Users/<user>/.vscode/extensions/humao.rest-client-0.24.1/dist/extension.js:252:4514)

Looks like some RegEx going wild 😄

@Huachao
Copy link
Owner

Huachao commented Jul 8, 2020

@vobu I have fixed this issue and will be published in the next release.

@Huachao Huachao closed this as completed Jul 8, 2020
@Huachao
Copy link
Owner

Huachao commented Aug 30, 2020

@vobu you can try the latest version 0.24.2

@vobu
Copy link
Author

vobu commented Sep 7, 2020

works! thanks!
🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants