Code snippet does not base64 encode the basic authentication header

[worawatt]

When creating code snippet from a request with basic authentication using user:password format, the Authorization in the snippet is not encoded with base64.

For example

GET https://httpbin.org/basic-auth/user/passwd HTTP/1.1
Authorization: Basic user:passwd

Result:

GET /basic-auth/user/passwd HTTP/1.1
User-Agent: vscode-restclient
Authorization: Basic user:passwd
Host: httpbin.org

But using user password format works correctly.

GET https://httpbin.org/basic-auth/user/passwd HTTP/1.1
Authorization: Basic user passwd

Result:

GET /basic-auth/user/passwd HTTP/1.1
User-Agent: vscode-restclient
Authorization: Basic dXNlcjpwYXNzd2Q=
Host: httpbin.org

Maybe because of this line where it splits the user and password using a space only:

vscode-restclient/src/controllers/codeSnippetController.ts

Line 194 in c7e783b

const params = authHeader.substr(start).trim().split(' ');

[Huachao]

@worawatt nice catch, I will publish this fix in the next release.

[Huachao]

@worawatt this has been fixed in the latest version 0.24.5 and you can have a try

[worawatt]

It works.
Thank you so much @Huachao.
This plugin is awesome, and I've always suggested it to my colleagues.