Add curl argument: --data-urlencode #1009
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huachao
reviewed
Jun 21, 2022
src/utils/curlRequestParser.ts
Outdated
| @@ -52,7 +52,7 @@ export class CurlRequestParser implements RequestParser { | |||
| } | |||
|
|
|||
| // parse body | |||
| let body = parsedArguments.d || parsedArguments.data || parsedArguments['data-ascii'] || parsedArguments['data-binary'] || parsedArguments['data-raw']; | |||
| let body = parsedArguments.d || parsedArguments.data || parsedArguments['data-ascii'] || parsedArguments['data-binary'] || parsedArguments['data-raw'] || parsedArguments['data-urlencode']; | |||
There was a problem hiding this comment.
For this case, do we need to do the URL encode work explictly?
There was a problem hiding this comment.
yeah, that has been added to the PR
bolthorn91
reviewed
Mar 21, 2023
src/utils/curlRequestParser.ts
Outdated
| @@ -52,7 +52,7 @@ export class CurlRequestParser implements RequestParser { | |||
| } | |||
|
|
|||
| // parse body | |||
| let body = parsedArguments.d || parsedArguments.data || parsedArguments['data-ascii'] || parsedArguments['data-binary'] || parsedArguments['data-raw']; | |||
| let body = parsedArguments.d || parsedArguments.data || parsedArguments['data-ascii'] || parsedArguments['data-binary'] || parsedArguments['data-raw'] || parsedArguments['data-urlencode']; | |||
There was a problem hiding this comment.
What about putting all arguments in array in order to scale or abstract if we need it? for example:
There was a problem hiding this comment.
Suggested change
| let body = parsedArguments.d || parsedArguments.data || parsedArguments['data-ascii'] || parsedArguments['data-binary'] || parsedArguments['data-raw'] || parsedArguments['data-urlencode']; | |
| const dataKeys = ['d', 'data', 'data-ascii', 'data-binary', 'data-raw', 'data-urlencode']; | |
| let body = parsedArguments[dataKeys.find(key => !!parsedArguments[key])]; |
mikecanann
requested review from
Huachao and
bolthorn91
and removed request for
Huachao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a command line argument for curl, called: --data-urlencode