Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to display Request Name as Tab Title #400

Merged
merged 5 commits into from
Aug 2, 2019
Merged

Add setting to display Request Name as Tab Title #400

merged 5 commits into from
Aug 2, 2019

Conversation

lochstar
Copy link
Contributor

@lochstar lochstar commented Aug 1, 2019

As outlined in #396, this works in conjunction with showResponseInDifferentTab.

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/views/httpResponseWebview.ts Outdated Show resolved Hide resolved
src/controllers/requestController.ts Outdated Show resolved Hide resolved
src/views/httpResponseWebview.ts Outdated Show resolved Hide resolved
@lochstar
Copy link
Contributor Author

lochstar commented Aug 1, 2019

I've made the suggested changes and also fixed it so the tab title is set when not displaying in a new tab. Let me know if there's anything else.

@Huachao Huachao merged commit 764cd1d into Huachao:master Aug 2, 2019
@Huachao
Copy link
Owner

Huachao commented Aug 2, 2019

@lochstar Merged, thanks.

@lochstar lochstar deleted the request-name-as-tab-title branch August 2, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants