Add support for the XDG directory specification #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cannot tell what is wrong with this PR. tslint passes locally for me. |
Huachao
reviewed
May 20, 2020
|
This pull request introduces 1 alert when merging cf92cc4 into 1ee0dbd - view on LGTM.com new alerts:
|
Huachao
reviewed
May 20, 2020
|
|
||
| if (process.env.XDG_CACHE_HOME !== undefined) { | ||
| return path.join(process.env.XDG_CACHE_HOME, restClientDir); | ||
| } |
There was a problem hiding this comment.
Just a question, if an existing user wants to use the XDG directory, he needs to delete the .rest-client folder first. And they also need to export these two environment variables in shell. right?
There was a problem hiding this comment.
Yes, the user would need to delete it and have the env variables exported. A lot of distributions have these exported by default.
Huachao
approved these changes
May 21, 2020
|
@tristan957 Merged, thanks |
|
Thanks very much for your review |
|
@tristan957 You can try this in the latest version 0.24.0 |
|
Perfect I'll let you know how it goes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a Linux user.
Linux users hate when people put dotfiles in the HOME folder.
I noticed your awesome extension <3 puts its folder in the HOME folder.
I implemented backwards-compatible support for the XDG directory specification[1].
In the case
~/.rest-clientexists, we continue to use that folder. Otherwise, we use bothXDG_CACHE_HOME/rest-clientandXDG_CONFIG_HOME/rest-client.So in my case as a previous user, I would just delete the current folder, and have the extension use the paths because I have those variables defined, as do most Linux users.
1: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html