Escape quotes for decodeEscapedUnicodeCharacters #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Treno1 could you please provide the curl response output without jq? A public endpoint is better. I think a valid serialized JSON string should encode |
|
curl -XGET "https://pastebin.com/raw/bZJP0r5i" |
Huachao
requested changes
Jun 9, 2020
src/utils/httpClient.ts
Outdated
| @@ -254,7 +254,10 @@ export class HttpClient { | |||
| } | |||
|
|
|||
| private decodeEscapedUnicodeCharacters(body: string): string { | |||
| return body.replace(/\\u([\d\w]{4})/gi, (_, g) => String.fromCharCode(parseInt(g, 16))); | |||
| return body.replace(/\\u([\d\w]{4})/gi, (_, g) => { | |||
| var char = String.fromCharCode(parseInt(g, 16)); | |||
src/utils/httpClient.ts
Outdated
| return body.replace(/\\u([\d\w]{4})/gi, (_, g) => String.fromCharCode(parseInt(g, 16))); | ||
| return body.replace(/\\u([\d\w]{4})/gi, (_, g) => { | ||
| var char = String.fromCharCode(parseInt(g, 16)); | ||
| return char == '\"' ? "\\\"" : char; |
src/utils/httpClient.ts
Outdated
| return body.replace(/\\u([\d\w]{4})/gi, (_, g) => String.fromCharCode(parseInt(g, 16))); | ||
| return body.replace(/\\u([\d\w]{4})/gi, (_, g) => { | ||
| var char = String.fromCharCode(parseInt(g, 16)); | ||
| return char == '\"' ? "\\\"" : char; |
There was a problem hiding this comment.
no need to escape the double quote in a single quote, we can simply write like this
return char === '"' ? '\\"' : char;
Thanks, some minor suggestions. |
|
@Treno1 Meged, thanks |
|
@Treno1 you can verify this in the latest version 0.24.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server sends me response as
My expectation was that decodeEscapedUnicodeCharacters will convert it to
But result was
{"text":""text""}with invalid json format errors.
Curl + jq handles that kind of situation perfectly.
So, small pr to fix that behaviour