Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#698 add :/ in scope regex to match #794

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

abdulkareemnalband
Copy link
Contributor

@abdulkareemnalband abdulkareemnalband commented Mar 17, 2021

{{$aadV2Token scopes:https://graph.windows.net/openid clientId: }}
fixes #698

@pschaeflein
Copy link

When calling custom apis that are protected by Azure AD, and if using the default values provided in the Azure Portal, you end up with a scope similar to api://<guid>/scope.name. (Or, if following some of the ASP.Net samples, the api://<guid>/scope_name).

In this scenario, \S is a better alternative than simply adding a semi-colon (:).

@drub0y
Copy link

drub0y commented Jun 15, 2021

Just hitting this myself now which really puts a stop to everything I was hoping to do with .rest files for my API which is secured with custom scopes that necessitate these currently invalid characters. Is there anything we can do to help get this PR pushed through?

While I agree with @pschaeflein change, the current change would at least technically address the issues for a lot of people. We can always do a follow up PR to use \S later.

@pschaeflein
Copy link

I've resorted to running a private install based on a fork. I asked about additional maintainers, but no "official" response...

#826

@Huachao Huachao merged commit ec9fd63 into Huachao:master Jul 2, 2021
@Huachao
Copy link
Owner

Huachao commented Jul 2, 2021

@abdulkareemnalband @pschaeflein @drub0y thanks for your PR and suggestions, and I have changed to use \S instead, this fix will be published in the next release.

@abdulkareemnalband abdulkareemnalband deleted the bugs/698-azure-ad-scopes branch July 2, 2021 05:02
@dracan
Copy link

dracan commented Nov 2, 2021

@Huachao - Do you know when this will be released? I've just hit the same issue too, and it's quite a blocker.

Ps. awesome work on this extension - it's amazing! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AADV2TokenProvider only works for special case of MS Graph Tokens
5 participants