Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new API for opening editor #89

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Conversation

d-akara
Copy link
Contributor

@d-akara d-akara commented Apr 6, 2017

This is a change to the open response in Untitled document.
VSCode 1.11 has a new parameter on the API which allows to set the content on opening.

I think this is better for these reasons:

  1. This allows the document to open without a previous undo. So if you hit undo, you will no longer get a blank document
  2. Since the document is opened in a state of not dirty, you can close the document without the editor giving you a popup asking if you want to close the document.

@Huachao Let me know what you think

Copy link
Owner

@Huachao Huachao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Huachao Huachao merged commit 2d9d0b9 into Huachao:master Apr 6, 2017
@Huachao
Copy link
Owner

Huachao commented Apr 6, 2017

@dakaraphi Merged, thanks. Really nice change.

@d-akara d-akara deleted the folding branch April 6, 2017 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants