fix a possible divided-by-zero bug #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we have poly_center.x /= cnt; poly_center.y /= cnt; in the code, we potentially face divided-by-zero issue when bboxes aren't intersecting with each other, as no intersection exists, cnt=0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since we have
poly_center.x /= cnt;
poly_center.y /= cnt;
in iou3d_kernel.cu, we potentially face divided-by-zero issue when bboxes aren't intersecting with each other, as no intersection exists, cnt=0. (We do encounter such issue during experiments.)
Modification
Add zero prevention for denominator. No changes at other places.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
No.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Higher stability for your scale-nms
Checklist
The correctness is checked via experiments.