Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use esm instead of amd, see riot/riot#1715. #3

Merged
merged 3 commits into from
Jun 3, 2016
Merged

Use esm instead of amd, see riot/riot#1715. #3

merged 3 commits into from
Jun 3, 2016

Conversation

dougludlow
Copy link
Contributor

This allows for the following within a .tag file:

import baz from './baz'
<tag>
   <script>
     this.foo = baz('bar');
   </script>
</tag>

@dougludlow
Copy link
Contributor Author

See riot/riot#1715.

@ffflabs
Copy link
Collaborator

ffflabs commented Jun 3, 2016

I'm sorry it took so long for me to notice your PR. Thank you for your contribution. It works perfectly.

However, I'm curious. Where are you setting the metadata to tell the loader to use esm?

@ffflabs ffflabs merged commit 40044d7 into HuasoFoundries:master Jun 3, 2016
@ffflabs
Copy link
Collaborator

ffflabs commented Jun 6, 2016

@dougludlow Released as v1.3.0

@dougludlow
Copy link
Contributor Author

@amenadiel sweet thanks! I'm setting the metadata in the jspm.config.js You can see an example of this here: https://github.com/MikeLarned/sialia/blob/458a97173be438bb7eed6322d77949af918e124c/jspm.config.js#L22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants