Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Inconsistency in cf files command #10

Open
wants to merge 1 commit into
base: hw-issue-12
Choose a base branch
from

Conversation

SrinivasChilveri
Copy link
Member

Before Fix: If cf user does
'cf files my-app' or 'cf files my-app path'
then its success but path is niehter optional not required

After Fix:If cf user does
'cf files my-app path'
then it will succ but 'cf files my-app' will fail
so path is now reqired parameter

http://rnd-github.huawei.com/paas/cli/issues/12#issuecomment-5478

Before Fix: If cf user does
'cf files my-app' or 'cf files my-app path'
then its success but path is niehter optional not required

After Fix:If cf user does
'cf files my-app path'
then it will succ  but 'cf files my-app' will fail
so path is now reqired parameter

http://rnd-github.huawei.com/paas/cli/issues/12#issuecomment-5478
@liuhewei
Copy link

@SrinivasChilveri As we discussed, this PR and issue should be kept open and following cf-cli's plan on V7.0.0.

@SrinivasChilveri
Copy link
Member Author

@liuhewei I have implemented PATH as required parameter.we have not received any info from pivotal to implement as required or optional parameter, so can i do one more PR with PATH as optional parameter? So we will be ready with two options what ever they want we can do PR for that. whats your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants