Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updated request instance count #2124

Merged
merged 4 commits into from
Jul 28, 2020
Merged

Fix updated request instance count #2124

merged 4 commits into from
Jul 28, 2020

Conversation

pschoenfelder
Copy link
Contributor

@pschoenfelder pschoenfelder commented Jul 27, 2020 •
edited
Loading

Instance counts in the UI are wrong when a deploy has an updated request because updatedRequest is a field of pendingDeployState, not of pendingDeploy.

ajammala
ajammala reviewed Jul 28, 2020
View reviewed changes
Copy link
Contributor

@ajammala ajammala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@pschoenfelder pschoenfelder merged commit 7027849 into master Jul 28, 2020
@pschoenfelder pschoenfelder deleted the scale-mismatch branch July 28, 2020 19:39
@ssalinas ssalinas added this to the 1.3.0 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajammala ajammala ajammala left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pschoenfelder @ajammala @ssalinas