HubSpot Backport: HBASE-28586 Backport HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tFormat2 to avoid always call getTableRelativePath method (apache#5888) Signed-off-by: Duo Zhang <zhangduo@apache.org>
ndimiduk
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports https://issues.apache.org/jira/browse/HBASE-28586 / https://issues.apache.org/jira/browse/HBASE-24791 to our fork. @mperez and I were wondering why a bulkload of a smaller size (hundreds of GB) was taking so long today and upon taking a flamegraph, HFileOutputFormat2#getTableRelativePath was revealed to be occupying 3x more CPU time than StoreFileWriter#append (which is the exact situation described in https://issues.apache.org/jira/browse/HBASE-24791)