Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor auth commands #1254

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Refactor auth commands #1254

merged 4 commits into from
Nov 22, 2024

Conversation

brandenrodgers
Copy link
Contributor

@brandenrodgers brandenrodgers commented Nov 22, 2024

Description and Context

Refactoring the auth commands to follow our new guidelines. Major change in here is that we're now using a standardized auth-type flag to represent the type of auth used for account authorization.

hs auth

  • Update description to: "Configure authentication for a HubSpot account."
  • Remove --version flag because it's unnecessary
  • The type positional should be converted to a flag and renamed to --auth-type
  • The account positional should be a flag, and it should support the short-hand -a option

hs init

  • Update description to: "Initialize the CLI config file and authenticate a HubSpot account."
  • Remove --version flag because it's unnecessary
  • The account positional should be a flag, and it should support the short-hand -a option
  • The --auth flag should become --auth-type

Screenshots

TODO

Who to Notify

@brandenrodgers brandenrodgers changed the base branch from main to next November 22, 2024 16:36
@brandenrodgers brandenrodgers merged commit f488c36 into next Nov 22, 2024
1 check passed
@brandenrodgers brandenrodgers deleted the br/refactor-auth-commands branch November 22, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants