Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Restructure custom-object commands to match design guidelines #1261

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

joe-yeager
Copy link
Contributor

@joe-yeager joe-yeager commented Nov 22, 2024

Description and Context

hs custom-object

  • Update description to: "[BETA] Commands for managing custom objects."
  • Remove all flags except for the --help flag because they don't do anything
  • Fix duplicate argument issue for config and account in nested commands
  • Support the plural as an alias: hs custom-objects
  • Remove support for the custom alias (too generic)

hs custom-object schema

  • Update description to: "Commands for managing custom object schemas."
  • support custom-object schemas as an alias

hs custom-object schema list

  • Update description to: "List custom object schemas."
  • Remove --version flag because it's unnecessary

hs custom-object schema fetch

  • Update description to: "Fetch a custom object schema."
  • Remove --version flag because it's unnecessary
  • Name should fall back to a prompt when not specified
  • dest should fall back to a prompt when not specified

hs custom-object schema fetch-all

  • dest should fall back to a prompt when not specified

hs custom-object schema create

  • Add a period to the end of the description
  • Remove --version flag because it's unnecessary
  • definition should be renamed to path and should be moved to be a flag instead of a positional

hs custom-object schema update

  • Add a period to the end of the description
  • definition should be renamed to path and should be moved to be a flag instead of a positional

hs custom-object schema delete

  • Add a period to the end of the description
  • Remove --version flag because it's unnecessary
  • Should list available schemas in a prompt when name is not included
  • should prompt for confirmation before deleting and support a --force flag to bypass the prompt

hs custom-object create

  • Add a period to the end of the description
  • definition should be renamed to path and should be moved to be a flag instead of a positional
  • Remove --version flag because it's unnecessary
  • Name should fall back to a prompt when not specified

@joe-yeager joe-yeager changed the title feat: Restructure custom-object commands to match design guidelines [WIP] feat: Restructure custom-object commands to match design guidelines Nov 22, 2024
@joe-yeager joe-yeager changed the title [WIP] feat: Restructure custom-object commands to match design guidelines [WIP] feat!: Restructure custom-object commands to match design guidelines Nov 22, 2024
@joe-yeager joe-yeager changed the title [WIP] feat!: Restructure custom-object commands to match design guidelines feat!: Restructure custom-object commands to match design guidelines Nov 22, 2024
@joe-yeager joe-yeager marked this pull request as ready for review November 22, 2024 23:21
Copy link
Contributor

@camden11 camden11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments/questions, nothing really blocking though

commands/customObject/schema/delete.ts Outdated Show resolved Hide resolved
commands/customObject/create.ts Show resolved Hide resolved
},
]);
return input;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we really just need to upgrade to the new inquirer haha

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah haha. The current version we are on its pretty unintuitive

@joe-yeager joe-yeager merged commit db92d75 into next Nov 26, 2024
1 check passed
@joe-yeager joe-yeager deleted the jy/resturcture-custom-object-commands branch November 26, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants