Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Restructure theme commands to match new design guidelines #1270

Merged
merged 5 commits into from
Nov 26, 2024
Merged

feat!: Restructure theme commands to match new design guidelines #1270

merged 5 commits into from
Nov 26, 2024

Conversation

joe-yeager
Copy link
Contributor

Description and Context

hs theme

  • Update description to: "Commands for managing themes."
  • Remove all flags except for the --help flag because they don't do anything
  • Support hs themes as a plural alias

hs theme marketplace-validate

  • Add a period to the description
  • src should be path
  • Remove --version flag

hs theme generate-selectors

  • Add a period to the description
  • themePath should be path
  • Remove --version flag

kemmerle
kemmerle reviewed Nov 25, 2024
View reviewed changes
commands/theme/preview.ts Outdated Show resolved Hide resolved
kemmerle
kemmerle reviewed Nov 25, 2024
View reviewed changes
commands/theme/preview.ts Outdated Show resolved Hide resolved
@joe-yeager joe-yeager requested a review from kemmerle November 25, 2024 16:29
brandenrodgers
brandenrodgers approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@brandenrodgers brandenrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment (mostly just a question because I'm not exactly sure where we landed on it), but otherwise lgtm 👌

@joe-yeager joe-yeager merged commit 83feeab into next Nov 26, 2024
1 check passed
@joe-yeager joe-yeager deleted the jy/restructure-theme-commands branch November 26, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandenrodgers brandenrodgers brandenrodgers approved these changes

@camden11 camden11 Awaiting requested review from camden11

@kemmerle kemmerle Awaiting requested review from kemmerle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe-yeager @brandenrodgers @kemmerle