Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getConfigDefaultAccount #1276

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

kemmerle
Copy link
Contributor

Description and Context

While working on #1273, I discovered that getConfigDefaultAccount was mistakenly being passed a config argument in a number of places. In fact, it takes zero arguments. This also had implications for the selectAccountFromConfig and deleteSandboxPrompt functions, both of which were being passed config unnecessarily to pass to getConfigDefaultAccount.

This PR removes a bunch of code. If you'd like to test out the changes, the impacted commands are:

hs accounts use
hs accounts list
hs accounts remove
hs auth
hs sandbox delete

TODO

  • Address feedback

Who to Notify

@brandenrodgers @camden11 @joe-yeager

@kemmerle kemmerle merged commit 372201a into convert/ts4 Dec 2, 2024
1 check passed
@kemmerle kemmerle deleted the fix/defaultaccountfunction branch December 2, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants