Fix bug in hs fetch
#1304
Merged
Fix bug in hs fetch
#1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemmerle
requested review from
brandenrodgers,
camden11 and
joe-yeager
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
I found a spare
accountIdvariable inhs fetchwhich was causing the command to fail. I replaced it withderivedAccountId.I performed a manual check of every command file where we refer to
accountIdto ensure that there were no more bugs, and I found none. We should be really careful not to introduce bugs before mergingnextintomainnext week.TODO
Who to Notify
@brandenrodgers @camden11 @joe-yeager