Determine a wee faster whether json_name matches the default
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following commit d809f18, this is to determine a wee faster whether a `json_name` matches the default generated one (returning a boolean as soon as possible, without a need to grow a `StringBuilder`).
Merged
|
I'm a bit weary of changing this function, I think it will be easier to maintain if it's just a direct copy. Also, we cache the result of this computation, so it should only get called once |
|
Fair enough. Closing the PR, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #103, this is to determine a wee faster whether a
json_namematches the default generated one (returning a boolean as soon as possible, without a need to grow aStringBuilder).