upgrade basepom, apply prettier formatting changes #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know the full context here, but wouldn't JDK baseline change suggest at least minor version bump? (I guess it's pre-1.0 so maybe the usual SemVer implications do not apply) |
|
good call; i have pinned this project back to jdk 8 pending futher review. the only technical reason our basepom moved to target 11 is a dep change on mockito from v4 to v5 (needed for jdk21 compilation). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades basepom version to 59, which includes some prettier formatting changes and dependency upgrades.
Basepom changed the target JDK from 8 to 11, but I've pinned this project at JDK 8 for now. I will still publish a release of 0.9.15 prior to merging this in, and apply this PR to the 0.9.16-SNAPSHOT version.