Added support for Unwrapped Serialization. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jhaber Can you kindly take a look at this ? This is very helpful for people requiring to flatten the json structure with embedded protobufs. |
|
Sorry for the delay, taking a look now |
jhaber
reviewed
Jul 29, 2022
src/main/java/com/hubspot/jackson/datatype/protobuf/builtin/serializers/MessageSerializer.java
Outdated
Show resolved
Hide resolved
|
Thanks for the PR, looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for Unwrapped Serialization . JsonUnwrapped annotation essentially creates a new instance of the MessageSerializer with "unwrapped" flag set to avoid generating the start and end object tags.
I have added test cases for the same as well.